Skip to content

[make:registration-form][make:reset-password] Refactor constraints to use named arguments #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

[make:registration-form][make:reset-password] Refactor constraints to use named arguments #1723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions src/Maker/MakeRegistrationForm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,9 +559,7 @@ private function generateFormClass(ClassNameDetails $userClassDetails, Generator
'options_code' => <<<EOF
'mapped' => false,
'constraints' => [
new IsTrue([
'message' => 'You should agree to our terms.',
]),
new IsTrue(message: 'You should agree to our terms.'),
],
EOF
],
Expand All @@ -573,15 +571,13 @@ private function generateFormClass(ClassNameDetails $userClassDetails, Generator
'mapped' => false,
'attr' => ['autocomplete' => 'new-password'],
'constraints' => [
new NotBlank([
'message' => 'Please enter a password',
]),
new Length([
'min' => 6,
'minMessage' => 'Your password should be at least {{ limit }} characters',
new NotBlank(message: 'Please enter a password'),
new Length(
min: 6,
minMessage: 'Your password should be at least {{ limit }} characters',
// max length allowed by Symfony for security reasons
'max' => 4096,
]),
max: 4096
),
],
EOF
],
Expand Down
14 changes: 6 additions & 8 deletions templates/resetPassword/ChangePasswordFormType.tpl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,13 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
],
'first_options' => [
'constraints' => [
new NotBlank([
'message' => 'Please enter a password',
]),
new Length([
'min' => 12,
'minMessage' => 'Your password should be at least {{ limit }} characters',
new NotBlank(message: 'Please enter a password'),
new Length(
min: 12,
minMessage: 'Your password should be at least {{ limit }} characters',
// max length allowed by Symfony for security reasons
'max' => 4096,
]),
max: 4096
),
new PasswordStrength(),
new NotCompromisedPassword(),
],
Expand Down
4 changes: 1 addition & 3 deletions templates/resetPassword/ResetPasswordRequestFormType.tpl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
->add('<?= $email_field ?>', EmailType::class, [
'attr' => ['autocomplete' => 'email'],
'constraints' => [
new NotBlank([
'message' => 'Please enter your email',
]),
new NotBlank(message: 'Please enter your email'),
],
])
;
Expand Down
Loading