Simplified the README instructions #676
Conversation
| > If you want to use a fully-featured web server (like Nginx or Apache) to run | ||
| > Symfony Demo application, configure it to point at the `web/` directory of the project. | ||
| > For more details, see: | ||
| > https://symfony.com/doc/current/cookbook/configuration/web_server_configuration.html |
There was a problem hiding this comment.
Should this note be removed entirely ? I think it might make sense to keep it. People using the symfony-demo to benchmark Symfony should hopefully do it with Apache/Nginx and PHP-FPM rather than using the single-threaded builtin webserver.
README.md
Outdated
|
|
||
| # if you're using Windows: | ||
| $ php symfony demo | ||
| $ composer create symfony/symfony-demo |
There was a problem hiding this comment.
I suggest using the actual name (create-project) rather than relying on the symfony/console shortcut feature. If someone has a global plugin installed providing a create command, this would run the wrong command.
|
|
||
| ```bash | ||
| $ cd symfony_demo/ | ||
| $ cd symfony-demo/ |
There was a problem hiding this comment.
It was on purpose because Symfony installer creates symfony_demo folder instead, i.e. when $ symfony demo. Do we completely drop Symfony installer support?
There was a problem hiding this comment.
Yes! But now with "composer create symfony/symfony-demo" it generates "symfony-demo/" so I think we must update this.
There was a problem hiding this comment.
If we remove Symfony installer from this README then 👍
There was a problem hiding this comment.
It's removed :) This is how the new README looks: https://github.com/javiereguiluz/symfony-demo/blob/5b68ac7205f7ef3c19115593170ba132279f48c6/README.md
3 participants
This is needed because we're moving away from the Symfony Installer and we'll use Composer's create-project from now on.