Setting tests directory consistent with src directory structure #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20uf
approved these changes
Aug 31, 2017
javiereguiluz
approved these changes
Aug 31, 2017
|
I totally missed this! Thanks for fixing it. |
javiereguiluz
added a commit
that referenced
this pull request
Aug 31, 2017
…cture (yceruto) This PR was merged into the master branch. Discussion ---------- Setting tests directory consistent with src directory structure > By convention, the `tests/AppBundle` directory should replicate the directory of your bundle for unit tests. So, if you're testing a class in the `src/AppBundle/Util/` directory, put the test in the `tests/AppBundle/Util/` directory. (http://symfony.com/doc/current/testing.html) The future version of it for 3.4/4.0 would be: > By convention, the `tests/` directory should replicate your `src` directory for unit tests. So, if you're testing a class in the `src/Util/` directory, put the test in the `tests/Util/` directory. Nothing to update in `composer.json` as PSR-4 autoload-dev section already known about this. ```json "autoload-dev": { "psr-4": { "App\\Tests\\": "tests/" } }, ``` Commits ------- ebfe702 Being consistent with src structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The future version of it for 3.4/4.0 would be:
Nothing to update in
composer.jsonas PSR-4 autoload-dev section already known about this.