Moving translations and templates folders to root folder #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstrom
changed the title
yceruto
reviewed
Jul 2, 2017
app/config/config.yml
Outdated
| # https://symfony.com/doc/current/book/http_cache.html#edge-side-includes | ||
| esi: { enabled: true } | ||
| translator: { fallback: '%locale%' } | ||
| translator: { fallback: '%locale%', paths: ["%kernel.project_dir%/translations"] } |
app/config/config.yml
Outdated
| - 'form/fields.html.twig' | ||
| paths: | ||
| "%kernel.project_dir%/templates/TwigBundle": Twig | ||
| "%kernel.project_dir%/templates": ~ |
|
@mstrom thanks A LOT for this contribution. Sadly, I must close for now as "won't fix" for the reasons explained by @yceruto. This is the dir structure used by Flex/Symfony 4 ... but we are not using any of those yet (we can't until November 2017). A similar, but different, proposal is #602 which moves assets dir. This is because the decision is based on Webpack Encore, which is a library independent from Flex/Sf4 and which we already use in this app. Thanks for understanding it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 4 will have templates folder under root folder
So I'm proposing to move templates to root folder for simplicity and translations as well