Update logs configuration #577
Conversation
app/config/config_dev.yml
Outdated
| path: "%env(SYMFONY_LOG)%" | ||
| level: info | ||
| type: stream | ||
| path: "%env(SYMFONY_LOG)%" |
There was a problem hiding this comment.
As a convention we're using single quotes ;)
There was a problem hiding this comment.
@ogizanagi, what about to use a name like LOG_URL for consistency with others variables names (DATABASE_URL, MAILER_URL)?
There was a problem hiding this comment.
In any case it would be APP_LOG_PATH (as it's the path to the log file), but I don't remember why is it configurable here, so by default it's '%kernel.logs_dir%/%kernel.environment%.log' :/
There was a problem hiding this comment.
LOG_URL makes sense to me. It's not only a path, it's a url used by the StreamHandler: https://github.com/Seldaek/monolog/blob/master/src/Monolog/Handler/StreamHandler.php#L50
|
@ogizanagi thanks for these changes. They are great and, as you said, they align nicely with the default Symfony practices. |
This PR was merged into the master branch. Discussion ---------- Update logs configuration to match the standard edition configuration, which is way more convenient. In dev, it'll now log every debug information but events, console errors are now logged natively and we don't need them to be output on stderr (we already have the stacktrace when running the console), and the `server:log` command allows to see logs in real-time. Commits ------- 96e7fc1 Update logs configuration
4 participants
to match the standard edition configuration, which is way more convenient.
In dev, it'll now log every debug information but events, console errors are now logged natively and we don't need them to be output on stderr (we already have the stacktrace when running the console), and the
server:logcommand allows to see logs in real-time.