Skip to content

Conversation

@elkuku
Copy link
Contributor

@elkuku elkuku commented Apr 11, 2017

This will add a command that checks foreign language translation files for missing strings.

Executing the command without arguments checks all language files:

2017-04-11-133404_1366x768_scrot

Providing a locale parameter only files for this locale will be checked and untranslated keys are displayed along with their fallback message.

2017-04-11-133508_1366x768_scrot

If everything is translated a <success> message will be displayed.

2017-04-11-134342_1366x768_scrot

This command is using the SymfonyStyle class to style the console output using the "Symfony style guide". I believe that also the other console commands should use this class to ensure a uniform display.

@elkuku elkuku mentioned this pull request Apr 11, 2017
javiereguiluz added a commit that referenced this pull request Apr 16, 2017
This PR was merged into the master branch.

Discussion
----------

Update translations es

Some missing spanish translations discovered by #531 😉

Commits
-------

844531a Minor changes
1527b49 Update translations es
@javiereguiluz
Copy link
Member

@elkuku thanks for this contribution. However, I must close it as "won't merge". Why? Because Symfony already provides a command for this: debug:translation.

It's true that your command is more specialized and quickly provides a summary for all locales, but adding it could confuse Symfony developers into thinking that they must develop this command themselves in their projects. That's why I'm closing it. I'm sorry but I hope you understand it. Thanks!

@jkufner
Copy link
Contributor

jkufner commented Apr 16, 2017

@elkuku I think this pull request should be posted to Symfony itself, rather than this demo app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants