-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Remove unused tag #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Remove unused tag #474
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <[email protected]> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace AppBundle\Repository; | ||
|
|
||
| use AppBundle\Entity\Post; | ||
| use AppBundle\Entity\Tag; | ||
| use Doctrine\ORM\EntityRepository; | ||
| use Doctrine\ORM\Query\ResultSetMapping; | ||
|
|
||
| /** | ||
| * This custom Doctrine repository contains some methods to about tags. | ||
| * | ||
| * See http://symfony.com/doc/current/book/doctrine.html#custom-repository-classes | ||
| */ | ||
| class TagRepository extends EntityRepository | ||
| { | ||
| /** | ||
| * Remove unused Tag from the Database. | ||
| */ | ||
| public function cleanUnusedTags() | ||
| { | ||
| $joinTable = $this->getEntityManager()->getClassMetadata(Post::class)->getAssociationMapping('tags')['joinTable']['name']; | ||
| $tagTable = $this->getClassMetadata()->getTableName(); | ||
| $unused_tags = $this->getEntityManager()->createNativeQuery(" | ||
| DELETE FROM `$tagTable` WHERE id IN | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Grafikart , try to use: DELETE FROM tags t
LEFT JOIN tags_posts j ON j.tag_id = t.id
WHERE j.tag_id IS NULL |
||
| ( | ||
| SELECT t.id FROM `$tagTable` t | ||
| LEFT JOIN `$joinTable` j ON j.tag_id = t.id | ||
| WHERE j.tag_id IS NULL | ||
| ) | ||
| ", new ResultSetMapping())->execute(); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate your contribution ... but using
$entityManager->transactionalis "light years" ahead of what we want to teach in the Symfony Demo app. I'm sorry but we can't use this obscure feature. We'll need to find a much simpler alternative solution. Thanks for understanding it.