Skip to content

Conversation

@ZCJ
Copy link

@ZCJ ZCJ commented Apr 21, 2015

Does't form->isValid already check id if the form has been submitted? Why do we need to check $form->isSubmitted()

Does't form->isValid already check id if the form has been submitted?
@javiereguiluz
Copy link
Member

@ZCJ thanks for preparing this pull request!

Technically, you are 100% right and the isSubmitted() method is not necessary. But we include it to improce code readability. In this closed pull request we explain the reasons: #2

To avoid any further issues with this line of code, we've added a help note in 3b14460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants