Skip to content

Conversation

@javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented May 5, 2022

Creating a "dark mode" style for this application is outside of the scope of the project, so we're not going to do it.

However, I propose to use a "dark mode" style to display the source code in the modal windows. In addition to being the most common style for developers, showing it in "dark mode" further emphasizes the difference between the application interface and its code:

Before / After

code-highlight-comparison

@bocharsky-bw
Copy link
Contributor

Looks better 👍

@javiereguiluz javiereguiluz force-pushed the dark_mode_code branch 2 times, most recently from d181022 to 960c779 Compare May 5, 2022 15:15
@t-richard
Copy link

showing it in "dark mode" further emphasizes the difference between the application interface and its code

This is the main argument here, it makes it stand out more from the rest of the app.

@EdwinLove
Copy link

👍

@javiereguiluz javiereguiluz merged commit 9b4e412 into symfony:main May 14, 2022
@javiereguiluz javiereguiluz deleted the dark_mode_code branch May 14, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants