Add various comments in the codebase #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Dec 16, 2021
src/Controller/BlogController.php
Outdated
| public function postShow(Post $post): Response | ||
| { | ||
| // Symfony's 'dump()' function is an improved version of PHP's 'var_dump()' but | ||
| // Symfony's 'dump()' and 'dd()' functions are an improved version of PHP's 'var_dump()' but |
Member
There was a problem hiding this comment.
dd is not just an improved var_dump. It is dump + die, which is quite different that just dumping.
Contributor
Author
There was a problem hiding this comment.
you are right, now the phrasing is weird
do you think I revert and adding the dd() is not worth it? or keep it but rephrase?
thank you @stof
94noni
force-pushed
the
ft-various-comments
branch
from
4c464c4 to
2b7005b
Compare
94noni
force-pushed
the
ft-various-comments
branch
from
2b7005b to
1f1e6b9
Compare
Member
|
Thanks Antoine! |
| * existing bundles that let you generate ready-to-use backends without effort. | ||
| * | ||
| * See http://knpbundles.com/keyword/admin | ||
| * See https://symfony.com/bundles/EasyAdminBundle/current/index.html |
Member
There was a problem hiding this comment.
I've replaced this link by https://symfony.com/bundle There are several admin bundles, so it's not fair to link specifically to one of them 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some comments while reading some source code
Ref https://symfony.com/doc/current/setup.html#the-symfony-demo-application