isValid checks whether submitted

[frag-seb]

I think the duplicate check is unnecessary, isValid checks if isSubmitted.

if ($form->isSubmitted() && $form->isValid()) {...}

example is here:

https://github.com/symfony/symfony-demo/blob/master/src/AppBundle/Controller/Admin/BlogController.php#L83

[JulienItard]

Best pratices :
Second, we recommend using $form->isSubmitted() in the if statement for clarity. This isn't technically needed, since isValid() first calls isSubmitted(). But without this, the flow doesn't read well as it looks like the form is always processed (even on the GET request).

[frag-seb]

I think the "isSubmitted" have only legitimation for

if(!isValid() && isSubmitted()) 

If you want to check something.

I'm assuming that it is submitted when it is vaild.

[xabbuh]

As @JulienItard said, the call to isSubmitted() is just made to make the intention more clear. It's perfectly valid to omit this call in your application, but the demo should comply with the best practices described in the documentation.

[bocharsky-bw]

Already closed in #49

[frag-seb]

Yes, it's alreasy. :D