fix typo in planning_reserves #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staadecker
approved these changes
Apr 18, 2021
|
I would call the later commit more of a change in behavior than a fix for errors. As far as I can tell, incremental and total capacity for storage gens were both being written to storage_builds.csv, but this is a request to split the output into storage_builds.csv and storage_capacity.csv to reduce confusion. I'm merging it on that basis, but expect to turn around and immediately combine this with some changes to gen_cap.csv, so there will be a gen_cap.csv and gen_additions.csv, and both of these will have columns for generator power capacity and energy capacity (the latter only applies to storage). |
staadecker
pushed a commit
that referenced
this pull request
Jan 28, 2023
fix typo in planning_reserves and split storage_builds.csv into storage_builds.csv and storage_capacity.csv
staadecker
pushed a commit
that referenced
this pull request
Jan 28, 2023
fix typo in planning_reserves and split storage_builds.csv into storage_builds.csv and storage_capacity.csv
staadecker
pushed a commit
that referenced
this pull request
Jan 29, 2023
fix typo in planning_reserves and split storage_builds.csv into storage_builds.csv and storage_capacity.csv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small typo in the file, which is fixed by this commit.