Skip to content

Conversation

@kateinoigakukun
Copy link
Member

No description provided.

StdlibUnittest is built with -disable-implicit-concurrency-module-import
and it uses concurrency feature. Therefore, without explicit import,
StdlibUnittest.swiftmodule doesn't have IMPORTED_MODULE entry of
_Concurrency. And it results link-failure when static linking because
swift_Concurrency is not linked.
Copy link
Member

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice 👍

@MaxDesiatov
Copy link
Member

Submitted upstream as swiftlang#39175

@MaxDesiatov MaxDesiatov merged commit 59ff6b4 into swiftwasm Sep 4, 2021
@kateinoigakukun kateinoigakukun deleted the katei/fix-missing-concurrency-link branch April 20, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants