Performance improvements

[MaxDesiatov]

Currently the transformation takes about 18-20 seconds, while the Rust version of wasm_transformer_cli takes about 1.3 seconds on average for a very basic single-file Wasm app.

[kateinoigakukun]

Could you give me usage code? Did you build it with release mode?

[MaxDesiatov]

It fails for me with -c release with WasmTransformer.InputByteStream.Error.invalidValueType(6). The code I'm using is main.swift from carton's TestApp. Reproducible in swiftwasm/carton#131 by running swift build -c release && cd TestApp && ../.build/release/carton dev in the root source directory of carton.

[MaxDesiatov]

BTW, building it on Linux with Swift 5.3 fails with this error:

swift: /home/buildnode/jenkins/workspace/oss-swift-5.3-package-linux-ubuntu-18_04/swift/lib/AST/Expr.cpp:1980: 
swift::Expr *swift::AutoClosureExpr::getUnwrappedCurryThunkExpr() const: Assertion `false && "Malformed curry thunk?"' failed.
Stack dump:
0.	Program arguments: /usr/share/swift/usr/bin/swift -frontend -c -primary-file /home/runner/work/carton/carton/.build/checkouts/WasmTransformer/Sources/WasmTransformer/BinaryFormat.swift -primary-file /home/runner/work/carton/carton/.build/checkouts/WasmTransformer/Sources/WasmTransformer/I64Transformer.swift -primary-file /home/runner/work/carton/carton/.build/checkouts/WasmTransformer/Sources/WasmTransformer/InputStream.swift -primary-file /home/runner/work/carton/carton/.build/checkouts/WasmTransformer/Sources/WasmTransformer/LEB128.swift /home/runner/work/carton/carton/.build/checkouts/WasmTransformer/Sources/WasmTransformer/OutputSections.swift /home/runner/work/carton/carton/.build/checkouts/WasmTransformer/Sources/WasmTransformer/OutputWriter.swift /home/runner/work/carton/carton/.build/checkouts/WasmTransformer/Sources/WasmTransformer/Trampoline.swift /home/runner/work/carton/carton/.build/checkouts/WasmTransformer/Sources/WasmTransformer/WasmTransformer.swift -supplementary-output-file-map /tmp/supplementaryOutputs-a32a16 -target x86_64-unknown-linux-gnu -disable-objc-interop -I /home/runner/work/carton/carton/.build/x86_64-unknown-linux-gnu/debug -enable-testing -g -module-cache-path /home/runner/work/carton/carton/.build/x86_64-unknown-linux-gnu/debug/ModuleCache -swift-version 5 -Onone -D SWIFT_PACKAGE -D DEBUG -enable-anonymous-context-mangled-names -parse-as-library -module-name WasmTransformer -o /home/runner/work/carton/carton/.build/x86_64-unknown-linux-gnu/debug/WasmTransformer.build/BinaryFormat.swift.o -o /home/runner/work/carton/carton/.build/x86_64-unknown-linux-gnu/debug/WasmTransformer.build/I64Transformer.swift.o -o /home/runner/work/carton/carton/.build/x86_64-unknown-linux-gnu/debug/WasmTransformer.build/InputStream.swift.o -o /home/runner/work/carton/carton/.build/x86_64-unknown-linux-gnu/debug/WasmTransformer.build/LEB128.swift.o -index-store-path /home/runner/work/carton/carton/.build/x86_64-unknown-linux-gnu/debug/index/store -index-system-modules 
1.	Swift version 5.3 (swift-5.3-RELEASE)
2.	While walking into decl 'transformElemSection(input:writer:trampolines:originalFuncCount:)' 
(at /home/runner/work/carton/carton/.build/checkouts/WasmTransformer/Sources/WasmTransformer/I64Transformer.swift:218:1)
3.	While walking into body of 'transformElemSection(input:writer:trampolines:originalFuncCount:)' 
(at /home/runner/work/carton/carton/.build/checkouts/WasmTransformer/Sources/WasmTransformer/I64Transformer.swift:218:1)

[MaxDesiatov]

I guess the compiler crash on Linux was fixed in swiftlang/swift#34131, we just need to wait for upstream 5.3.1 release? 🤔
But it's an AST assertion, so I hope there's a way to rewrite it to work around it in the meantime.

[MaxDesiatov]

I moved the AST assertion breakage report to #6.