Add basic GDB remote protocol encoding/decoding #204
+1,138
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
commented
Oct 8, 2025
There was a problem hiding this comment.
Added separate Package.swift manifest to hide debugger support behind a trait for now, and traits aren't supported in 6.0.
MaxDesiatov
commented
Oct 8, 2025
MaxDesiatov
commented
Oct 8, 2025
MaxDesiatov
commented
Oct 8, 2025
Comment on lines
123
to
132
| .target(name: "GDBRemoteProtocol", | ||
| dependencies: [ | ||
| .product(name: "NIOCore", package: "swift-nio"), | ||
| ] | ||
| ), | ||
| .testTarget(name: "GDBRemoteProtocolTests", dependencies: ["GDBRemoteProtocol"]), |
There was a problem hiding this comment.
These two modules are meant to be completely independent of WasmKit and in the future could live in a separate package to be adopted in any suitable environment that needs debugging facilities, not just Wasm.
MaxDesiatov
commented
Oct 8, 2025
MaxDesiatov
commented
Oct 9, 2025
MaxDesiatov
force-pushed
the
maxd/lldb-remote-protocol
branch
2 times, most recently
from
c6bb762 to
e2be1c7
Compare
weissi
reviewed
Oct 14, 2025
weissi
reviewed
Oct 14, 2025
weissi
reviewed
Oct 14, 2025
MaxDesiatov
commented
Oct 15, 2025
MaxDesiatov
changed the title
MaxDesiatov
changed the title
qWasmCallStack
MaxDesiatov
changed the title
qWasmCallStackqWasmCallStack
There was a problem hiding this comment.
What do you think about landing the GDBRemoteProtocol module to the main branch first, then land the remaining engine changes?
I'd like to review the engine changes carefully not to regress performance and spec compliant, so splitting them would help me a lot 🙏
MaxDesiatov
force-pushed
the
maxd/lldb-remote-protocol
branch
2 times, most recently
from
35bc821 to
2d065e0
Compare
MaxDesiatov
force-pushed
the
maxd/lldb-remote-protocol
branch
3 times, most recently
from
fed04da to
17f9d5f
Compare
MaxDesiatov
force-pushed
the
maxd/lldb-remote-protocol
branch
from
17f9d5f to
16ac0cf
Compare
MaxDesiatov
changed the title
qWasmCallStack
MaxDesiatov
commented
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GDB and LLDB remote protocol documentation for more details: