Rename ref to jsObject on JSDate for consistency with JSError
#50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a useful thing to have public so users can access the raw JS value if necessary. |
MaxDesiatov
changed the title
ref private on JSDateref to jsObject on JSDate for consistency with JSError
MaxDesiatov
changed the title
ref to jsObject on JSDate for consistency with JSErrorref to jsObject on JSDate for consistency with JSError
MaxDesiatov
changed the title
ref to jsObject on JSDate for consistency with JSErrorref to jsObject on JSDate for consistency with JSError
kateinoigakukun
approved these changes
Sep 15, 2020
No idea why I made it `public` in the first place...
MaxDesiatov
force-pushed
the
jsdate-ref-private
branch
from
ea3d608 to
5c0cead
Compare
j-f1
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that
jsObjectname is more representative than plainref, and as Jed correctly points out, it should be public after all for users to access it if necessary.Also, more doc comments are added to
JSDatewith existing ones refined.