Skip to content

Change JSClosure.release to deinit #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2020
Merged

Change JSClosure.release to deinit #33

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4082c87
Change `JSClosure.release` to `deinit`
MaxDesiatov Aug 4, 2020
498b6ba
Rename test case in PrimaryTests
MaxDesiatov Aug 4, 2020
b4042fa
Add newline to `PrimaryTests/main.swift`
MaxDesiatov Aug 4, 2020
3420079
Add `isRelease` property to `JSClosure`
MaxDesiatov Aug 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions IntegrationTests/TestSuites/Sources/PrimaryTests/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,6 @@ Host_Function_Registration: do {
try expectEqual(call_host_1Func(), .number(1))
try expectEqual(isHostFunc1Called, true)

hostFunc1.release()

let hostFunc2 = JSClosure { (arguments) -> JSValue in
do {
let input = try expectNumber(arguments[0])
Expand All @@ -220,7 +218,6 @@ Host_Function_Registration: do {

try expectEqual(hostFunc2(3), .number(6))
_ = try expectString(hostFunc2(true))
hostFunc2.release()
} catch {
print(error)
}
Expand Down Expand Up @@ -334,3 +331,16 @@ ObjectRef_Lifetime: do {
} catch {
print(error)
}

func closureScope() -> ObjectIdentifier {
let closure = JSClosure { _ in .undefined }
return ObjectIdentifier(closure)
}

Closure_Identifiers: do {
let oid1 = closureScope()
let oid2 = closureScope()
try expectEqual(oid1, oid2)
} catch {
print(error)
}
2 changes: 1 addition & 1 deletion Sources/JavaScriptKit/JSFunction.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public class JSClosure: JSFunctionRef {
id = objectRef
}

public func release() {
deinit {
Self.sharedFunctions[hostFuncRef] = nil
}
}
Expand Down