Skip to content

Update macro conditions for runtime usage #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2024
+3 −3
Merged

Update macro conditions for runtime usage #257

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f4e95e
Update macro conditions for runtime usage
fjtrujy Jul 30, 2024
8611b7a
Distinguish 6.0 and main toolchains by `hasFeature(Extern)`
kateinoigakukun Jul 30, 2024
b7f67c6
Using IsolatedAny2 instead Extern
fjtrujy Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/JavaScriptEventLoop/JavaScriptEventLoop.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public final class JavaScriptEventLoop: SerialExecutor, @unchecked Sendable {
return _shared
}

#if compiler(>=6.0) && _runtime(_multithreaded)
#if compiler(>=6.1) && _runtime(_multithreaded)
// In multi-threaded environment, we have an event loop executor per
// thread (per Web Worker). A job enqueued in one thread should be
// executed in the same thread under this global executor.
Expand Down
2 changes: 1 addition & 1 deletion Sources/JavaScriptEventLoop/WebWorkerTaskExecutor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#if compiler(>=6.0) && _runtime(_multithreaded) // @_expose and @_extern are only available in Swift 6.0+
#if compiler(>=6.1) && _runtime(_multithreaded) // @_expose and @_extern are only available in Swift 6.0+

import JavaScriptKit
import _CJavaScriptKit
Expand Down
2 changes: 1 addition & 1 deletion Tests/JavaScriptEventLoopTests/WebWorkerTaskExecutorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#if compiler(>=6.0) && _runtime(_multithreaded)
#if compiler(>=6.1) && _runtime(_multithreaded)
import XCTest
import JavaScriptKit
import _CJavaScriptKit // For swjs_get_worker_thread_id
Expand Down