Skip to content

Fix recursion in TypedArray initializer #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 21, 2021
Merged

Fix recursion in TypedArray initializer #142

merged 5 commits into from
Nov 21, 2021

Conversation

PatrickPijnappel
Copy link
Contributor

The original unconstrained version would cause infinite recursion.

MaxDesiatov
MaxDesiatov requested changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great catch! Would you be able to add a test that covers this?

MaxDesiatov
MaxDesiatov approved these changes Nov 21, 2021
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a simple test, which I hope is enough, but let me know it doesn't reflect the code you've used to reproduce this on your side.

@MaxDesiatov MaxDesiatov merged commit 9e2f414 into swiftwasm:main Nov 21, 2021
@PatrickPijnappel
Copy link
Contributor Author

@MaxDesiatov that looks good! Sorry I didn't get to this earlier had been really busy.

@MaxDesiatov
Copy link
Contributor

No problem, thanks again for the PR!

@PatrickPijnappel PatrickPijnappel deleted the patch-1 branch March 22, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrickPijnappel @MaxDesiatov