Skip to content

Test parameterized test children aren't runnable #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Test parameterized test children aren't runnable #1158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 35 additions & 9 deletions test/integration-tests/testexplorer/TestExplorerIntegration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
//
//===----------------------------------------------------------------------===//

import * as assert from "assert";
import * as vscode from "vscode";
import { beforeEach, afterEach } from "mocha";
import { testAssetUri } from "../../fixtures";
Expand All @@ -35,6 +36,11 @@ import {
TestSymbol,
} from "../../../src/TestExplorer/TestParsers/SwiftTestingOutputParser";
import { mockGlobalObject } from "../../MockUtils";
import {
flattenTestItemCollection,
reduceTestItemChildren,
} from "../../../src/TestExplorer/TestUtils";
import { runnableTag } from "../../../src/TestExplorer/TestDiscovery";

suite("Test Explorer Suite", function () {
const MAX_TEST_RUN_TIME_MINUTES = 5;
Expand Down Expand Up @@ -513,16 +519,13 @@ suite("Test Explorer Suite", function () {
});

test(`Runs parameterized test (${runProfile})`, async function () {
const testRun = await runTest(
testExplorer,
runProfile,
"PackageTests.parameterizedTest(_:)"
);
const testId = "PackageTests.parameterizedTest(_:)";
const testRun = await runTest(testExplorer, runProfile, testId);

assertTestResults(testRun, {
passed: [
"PackageTests.parameterizedTest(_:)/PackageTests.swift:59:2/argumentIDs: Optional([Testing.Test.Case.Argument.ID(bytes: [49])])",
"PackageTests.parameterizedTest(_:)/PackageTests.swift:59:2/argumentIDs: Optional([Testing.Test.Case.Argument.ID(bytes: [51])])",
`${testId}/PackageTests.swift:59:2/argumentIDs: Optional([Testing.Test.Case.Argument.ID(bytes: [49])])`,
`${testId}/PackageTests.swift:59:2/argumentIDs: Optional([Testing.Test.Case.Argument.ID(bytes: [51])])`,
],
failed: [
{
Expand All @@ -532,14 +535,37 @@ suite("Test Explorer Suite", function () {
text: "Expectation failed: (arg → 2) != 2",
})}`,
],
test: "PackageTests.parameterizedTest(_:)/PackageTests.swift:59:2/argumentIDs: Optional([Testing.Test.Case.Argument.ID(bytes: [50])])",
test: `${testId}/PackageTests.swift:59:2/argumentIDs: Optional([Testing.Test.Case.Argument.ID(bytes: [50])])`,
},
{
issues: [],
test: "PackageTests.parameterizedTest(_:)",
test: testId,
},
],
});

// Verifiy that the children of the parameterized test are not runnable
const parameterizedTestItem = flattenTestItemCollection(
testExplorer.controller.items
).find(item => item.id === testId);

assert.ok(
parameterizedTestItem,
`Unable to find ${testId} in test explorer children`
);

const unrunnableChildren = reduceTestItemChildren(
parameterizedTestItem?.children ?? [],
(acc, item) => {
return [
...acc,
item.tags.find(tag => tag.id === runnableTag.id) === undefined,
];
},
[] as boolean[]
);

assert.deepEqual(unrunnableChildren, [true, true, true]);
});

test(`Runs Suite (${runProfile})`, async function () {
Expand Down