Attempt to clarify the deallocation rules for UMBP. #85101
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glessard
approved these changes
Oct 24, 2025
Contributor
glessard
left a comment
glessard
left a comment
There was a problem hiding this comment.
Minor quibbles, but there's nothing wrong with the message.
| /// intPointer.deallocate() | ||
| /// | ||
| /// You should only use `deallocate()` to end the lifetime of memory | ||
| /// created with `allocate()`; it is a programming error to use `free` or |
Contributor
There was a problem hiding this comment.
Should we call out free() explicitly, or should we say "other deallocation functions", or maybe "deallocation functions from other libraries"
Contributor
Author
There was a problem hiding this comment.
Yeah, I was torn on this. But I feel like free is the primary means of abuse, and anyone who was going to use anything else that they shouldn't will understand that the rules for free apply to them as well.
Co-authored-by: Guillaume Lessard <[email protected]>
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test macOS |
speednoisemovement
pushed a commit
to speednoisemovement/swift
that referenced
this pull request
Oct 29, 2025
resolves rdar://162944521 --------- Co-authored-by: Guillaume Lessard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves rdar://162944521