Fix -Wdangling-assignment-gsl warnings #84959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
ping |
cachemeifyoucan
force-pushed
the
PrunedLiveness-warning
branch
from
885002b to
457984a
Compare
cachemeifyoucan
requested review from
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
cachemeifyoucan
changed the title
Contributor
Author
|
@swift-ci please smoke test |
slavapestov
approved these changes
Oct 20, 2025
tshortli
reviewed
Oct 20, 2025
lib/Sema/TypeCheckType.h
Outdated
| return unboundTyOpener; | ||
| } | ||
|
|
||
| static Type defaultUnbountTypeOpener(UnboundGenericType *ty) { |
Contributor
There was a problem hiding this comment.
Suggested change
| static Type defaultUnbountTypeOpener(UnboundGenericType *ty) { | |
| static Type defaultUnboundTypeOpener(UnboundGenericType *ty) { |
Contributor
Author
There was a problem hiding this comment.
Good typo catch.
Fix new clang warnings that can indicate potential use-after-free from dangling pointers. The issues are mostly coming from `llvm::function_ref` are not owning the function, and `std::function` should be used in those cases.
cachemeifyoucan
force-pushed
the
PrunedLiveness-warning
branch
from
457984a to
a7d7def
Compare
Contributor
Author
|
@swift-ci please smoke test |
grynspan
approved these changes
Oct 20, 2025
Contributor
Author
|
@swift-ci please smoke test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix new clang warnings that can indicate potential use-after-free from
dangling pointers.
The issues are mostly coming from
llvm::function_refare not owningthe function, and
std::functionshould be used in those cases.