-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Windows: migrate to experimental SDK, stabilize toolchain, and remove legacy SDK #84797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
@swift-ci please smoke test |
fafc9ad to
1edbb62
Compare
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
1 similar comment
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
a24766f to
f825a55
Compare
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
f825a55 to
4e18a3d
Compare
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
4e18a3d to
71ed808
Compare
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
71ed808 to
9341f36
Compare
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
1 similar comment
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
41d370a to
cfdd5e0
Compare
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
2 similar comments
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
cfdd5e0 to
b2fb6f5
Compare
b2fb6f5 to
8478355
Compare
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
8478355 to
58e2742
Compare
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
58e2742 to
c40d883
Compare
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
2 similar comments
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
We would use `clang++` to build the tests rather than `clang-cl` which should be preferred when building with the MSVC-like command line.
Adjust the toolchain build to use the pinned toolchain rather than the built toolchain. This is particularly important with the lack of ABI stability on Windows. We now uniformly build the toolchain with the same runtime. This extricates the SDK from the toolchain build. Now that we build the toolchain properly against a SxS installable version of the runtime, we can consume the runtime that we built against and inject that into the toolchain image. This avoids the need to rely on trying to maintain ABI compatibility in an ABI unstable environment.
Drop the support for the legacy build system for the runtime. This reduces the complexity in the build script as well as helps reduce the overall build times.
Build the complete toolchain before we build the SDK. This delays a certain class of errors, however, the resulting build order is much easier to reason about.
10ddf07 to
91466e1
Compare
This set of changes: