Rename the new _GUID clang module to _GUIDDef.
#84466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the name of the clang module introduced in #83914 from `_GUID` to `_GUIDDef`. This change is necessary because the Windows SDK declares a type named `_GUID` and Swift gets confused when a module and a type have the same name. This confusion is the motivation for [SE-0491](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0491-module-selectors.md), but we can't just wait for a fix because the new module is a source-breaking change and clients won't be able to adopt the proposed syntax for some time.
grynspan
added
bug
Contributor
Author
|
@swift-ci test |
egorzhdan
approved these changes
Sep 23, 2025
compnerd
approved these changes
Sep 23, 2025
2 tasks
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Oct 6, 2025
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Oct 6, 2025
This reverts commit 1628d2d.
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Oct 6, 2025
This reverts commit 11b37b1.
grynspan
added a commit
to swiftlang/swift-testing
that referenced
this pull request
Oct 7, 2025
This reverts commit e5f0002.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the name of the clang module introduced in #83914 from
_GUIDto_GUIDDef. This change is necessary because the Windows SDK declares a type named_GUIDand Swift gets confused when a module and a type have the same name.This confusion is the motivation for SE-0491, but we can't just wait for a fix because the new module is a source-breaking change and clients won't be able to adopt the proposed syntax for some time.