[cxx-interop] Basic support for anonymous structs with non-copyable fields #84105
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ields Anonymous structs cannot be copied or moved, these operations only can happen to their enclosing non-anonymous types. Stop trying to emit special member functions and value witness tables for these structs.
Xazax-hun
requested review from
egorzhdan,
fahadnayyar,
hnrklssn,
j-hui,
rjmccall,
susmonteiro and
zoecarver
as code owners
Xazax-hun
requested review from
beccadax and
ian-twilightcoder
as code owners
Contributor
Author
|
@swift-ci please smoke test |
Xazax-hun
added a commit
to Xazax-hun/swift
that referenced
this pull request
Sep 5, 2025
…ble fields Explanation: Anonymous structs cannot be copied or moved, these operations only can happen to their enclosing non-anonymous types. Stop trying to emit special member functions and value witness tables for these structs. This fix is required to unblock a high priority libc++ change that fixes an unintended ABI break. Issues: rdar://159928354 Original PRs: swiftlang#84105 Risk: Medium. I believe this is the right change but hard to anticipate if something depends on the presence of these operations (which is likely to be a bug). But this is required to unblock an important libc++ fix. Testing: Added a compiler test. Reviewers: @rjmccall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anonymous structs cannot be copied or moved, these operations only can happen to their enclosing non-anonymous types. Stop trying to emit special member functions and value witness tables for these structs.