Add a new frontend flag to emit inferred types at a given cursor position as remarks #84032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
hborla,
slavapestov,
xedin,
artemcm,
tshortli and
DougGregor
as code owners
|
@swift-ci smoke test |
|
macOS failure is Swift(macosx-x86_64) :: Concurrency/async_task_priority.swift, which should be unrelated |
|
@swift-ci smoke test macOS |
xedin
reviewed
Sep 2, 2025
| @@ -1391,6 +1391,43 @@ bool constraints::debugConstraintSolverForTarget( | |||
| return startBound != endBound; | |||
| } | |||
|
|
|||
| bool constraints::shouldEmitInferredTypesRemarksForTarget( | |||
There was a problem hiding this comment.
I think I a better place for this is TypeCheckConstraints.cpp
| auto diag = Context.Diags.diagnose(E->getStartLoc(), | ||
| diag::remark_inferred_type, | ||
| E->getKind(), type); | ||
| diag.highlight(E->getSourceRange()); |
There was a problem hiding this comment.
This is emitting remarks for all the types inferred or not, do we actually want inferred types only?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily intended to be used (along with #84031) by tools like sourcekit-lsp to opt in to additional annotations for the subset of a file the user is currently looking at. This initial remark is fairly simple and limited, but it serves as a good foundation for future experimentation in this space around exposing more of the compiler's internal analysis to higher-level tools.