Skip to content

[6.2] SILCombine: fix convert_function -> apply peephole for generic function types #83947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

[6.2] SILCombine: fix convert_function -> apply peephole for generic function types #83947

merged 1 commit into from
Aug 28, 2025

Conversation

@eeckstein
Copy link
Contributor

@eeckstein eeckstein commented Aug 27, 2025

  • Explanation: Fixes a crash in a SILCombine peephole optimization which simplifying apply instructions of convert_function instructions. We cannot deal with generic arguments/returns. Therefore bail in this case.
  • Risk: Low. It's a simple fix which adds an additional bail-out condition to the peephole optimization.
  • Testing: Tested by a lit test.
  • Issue: rdar://158809851
  • Reviewer: @nate-chandler
  • Main branch PR: SILCombine: fix convert_function -> apply peephole for generic function types #83912

@eeckstein
SILCombine: fix convert_function -> apply peephole for generic fu…
bf3a05b 
…nction types

Currently we cannot deal with generic arguments/returns. Bail in this case.

Fixes a compiler crash
rdar://158809851
@eeckstein eeckstein requested a review from a team as a code owner August 27, 2025 15:42
@eeckstein
Copy link
Contributor Author

eeckstein commented Aug 27, 2025

@swift-ci test

@eeckstein eeckstein merged commit 6713168 into swiftlang:release/6.2 Aug 28, 2025
5 checks passed
@eeckstein eeckstein deleted the fix-combine-apply-of-convertfunction-6.2 branch August 28, 2025 04:38
@eeckstein eeckstein mentioned this pull request Aug 28, 2025
Merged
@eeckstein eeckstein mentioned this pull request Nov 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbkka tbkka tbkka approved these changes

Assignees

No one assigned

Labels

swift 6.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eeckstein @tbkka