[CSOptimizer] All the candidates should match Any parameter type
#83703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the parameter is `Any` we assume that all candidates are convertible to it, which makes it a perfect match. The solver would then decide whether erasing to an existential is preferable. Resolves: rdar://157644867
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
slavapestov
reviewed
Aug 13, 2025
| } | ||
| } | ||
|
|
||
| // If the parameter is `Any` we assume that all candidates are |
Contributor
There was a problem hiding this comment.
What if the type is non-Copyable or non-Escapable? Does any ~Copyable need a special case too?
Contributor
Author
There was a problem hiding this comment.
We'd let the solver decide what to do with that, the idea here is to avoid filtering it out which would mean it won't be attempted at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the parameter is
Anywe assume that all candidates are convertible to it, which makes it a perfect match. The solver would then decide whether erasing to an existential is preferable.Resolves: rdar://157644867