[IDE] Erase archetypes without declaration generic signature #83652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7medev
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
a7medev
force-pushed
the
feat/generalize-erase-archetypes
branch
from
5376af0 to
4e2cb0b
Compare
a7medev
force-pushed
the
feat/generalize-erase-archetypes
branch
2 times, most recently
from
7c24e93 to
7d58998
Compare
Member
Author
|
@hamishknight BTW I feel like these comments belong to #83646, I understand that GitHub shows everything in this PR due to the lack of a real base branch 🥲. Should we keep the PRs separate or do we join them? |
Contributor
|
Yeah sorry I forgot you had split them, I'll leave follow-up feedback on the other PR. The |
a7medev
force-pushed
the
feat/generalize-erase-archetypes
branch
2 times, most recently
from
26aabc6 to
0357d7d
Compare
hamishknight
approved these changes
Aug 27, 2025
Contributor
This generalization enables curried functions with generic parameters coming from the initial declaration to be printed with the archetype's upperbound rather than '_' unresolved type. As an added benefit, T.self and T.Type for generic parameters now get shown as the upperbound of the generic parameter provided
a7medev
force-pushed
the
feat/generalize-erase-archetypes
branch
from
0357d7d to
491b3a0
Compare
Contributor
|
@swift-ci please test |
Contributor
|
@swift-ci please smoke test macOS |
Member
Author
|
@hamishknight I've checked the macOS failure, looks like an issue with swift-docc tests, any idea why that could is happening? |
Contributor
|
Yeah that's unrelated, let's land this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR depends on #83646 and it should be set as this PR's base but GitHub doesn't allow this.
Commit 5376af0c67aaacf104b54c42575ed03513fe3b92 is the only change added in this PR.
The
swift::ide::eraseArchetypesfunction is used in code completion to replace archetypes with their upper bound for completion string printing.Currently, it checks for a provided generic signature before doing anything and returns immediately if no generic signature is provided. This shouldn't be necessary for archetypes though since they carry their generic signature.
This PR enables more helpful code completion results for things like
.selfand.Typeand more generally for types without an explicit generic signature attached.