[cxx-interop] Fix passing optional CoreFoundation types from Swift to C++ #83609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… C++ These types are passed around as reference counted pointers, so the optional representation of them are nullable pointers. Previously, we tried to wrap them in swift::Optional. rdar://157667946
Xazax-hun
requested review from
egorzhdan,
fahadnayyar,
hnrklssn,
j-hui,
susmonteiro and
zoecarver
as code owners
Contributor
Author
|
@swift-ci please smoke test |
hnrklssn
approved these changes
Aug 8, 2025
Contributor
Author
|
@swift-ci please smoke test macOS |
Xazax-hun
added a commit
to Xazax-hun/swift
that referenced
this pull request
Sep 3, 2025
…ft to C++ ExplanationThese types are passed around as reference counted pointers, so the optional representation of them are nullable pointers. Previously, we tried to wrap them in swift::Optional. Issues: rdar://157667946 Original PRs: swiftlang#83609 Risk: Low, the fix is narrow. Testing: Added a compiler test. Reviewers: @hnrklssn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types are passed around as reference counted pointers, so the optional representation of them are nullable pointers. Previously, we tried to wrap them in swift::Optional.
rdar://157667946