[SILCombine] Skip load-only unchecked_take_enum_data_addr with noncopyable base. #83404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pass rewrites `unchecked_take_enum_data_addr` whose uses are all loads as loads--with the same ownership--of the base followed by `unchecked_enum_data`s. If the base is noncopyable and any of the loads are `load [copy]`, performing this transformation would result in a copy of that noncopyable base, which is invalid. So bail if the base is noncopyable and any of the loads are `load [copy]`s. rdar://156543855
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please apple silicon benchmark |
Contributor
Author
|
@swift-ci please test source compatibility |
nate-chandler
changed the title
Contributor
Author
|
@swift-ci please test macos platform |
Contributor
Author
|
@swift-ci please test macos platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pass rewrites
unchecked_take_enum_data_addrwhose uses are all loads as loads--with the same ownership--of the base followed byunchecked_enum_datas. If the base is noncopyable and any of the loads areload [copy], performing this transformation would result in a copy of that noncopyable base, which is invalid. So bail if the base is noncopyable and any of the loads areload [copy]s.rdar://156543855