Fix assertion in InstructionDeleter::trackIfDead. #83390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assertion was triggering when deleting scope-ending operations whose operand had been replaced with an undef: end_borrow undef Related to rdar://156431548 This was triggered during simplify-cfg by after adding blocks to the worklist, then later cleaning up dead instructions in the worklist blocks. I'm unable to create a test case based on simplify-cfg because the assertion is completely unrelated to the optimization that adds blocks to the worklist.
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci smoke test macOS |
meg-gupta
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assertion was triggering when deleting scope-ending operations whose
operand had been replaced with an undef:
end_borrow undef
Related to rdar://156431548
This was triggered during simplify-cfg by after adding blocks to the worklist,
then later cleaning up dead instructions in the worklist blocks. I'm unable to
create a test case based on simplify-cfg because the assertion is completely
unrelated to the optimization that adds blocks to the worklist.