[6.2] Fix lengthOfBytes(using:) semantics #83340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit ea7c3d4)
Contributor
Author
|
@swift-ci please test |
Catfish-Man
changed the title
tbkka
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit ea7c3d4)
Explanation:
Due to an oversight the Foundation tests were run against the OS stdlib when testing a previous fix, so missed that I accidentally changed the semantics of this method from "byte count" to "code point count". This fixes it and adds stdlib tests so we don't have to rely on Foundation's tests.
Resolves: rdar://156675395
Risk: Low. Trivial changes, verified with a new test
Main branch PR: #83334
Review by: @jrflat, @glessard
Testing: new test for this method, verified using the old implementation