IRGen: correct some type deletion #83321
Merged
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please smoke test |
ASAN identified mismatched `operator new` and `operator delete` on these types. The reason for this is the sized allocation for the tail packing involved. Provide the associated `operator delete` that releases the memory. Note that the `operator delete` is static and does not have the implicit `this` pointer, and we cannot use the name `this` for the variable.
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
I'm going to merge this - this fixes errors that ASAN identified and I'm hoping it might help uncover other issues so we can find the root cause of the flakiness in building Foundation where we abnormally exit. |
Contributor
|
I think this has broken something — my local build is complaining it can't find a matching |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASAN identified mismatched
operator newandoperator deleteon these types. The reason for this is the sized allocation for the tail packing involved. Provide the associatedoperator deletethat releases the memory. Note that theoperator deleteis static and does not have the implicitthispointer, and we cannot use the namethisfor the variable.