Embedded Swift: Fix === and !== with existential #83308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's difficult to trigger this because the code path is only reached for the standard operators. The issue in question was in embedded Swift due to an unsupported usage of the === operator, but we expect an upcoming standard library change to actually make us accept that code. However, the fix should be pretty safe, even without a test case. Fixes the crash in rdar://156095800.
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
slavapestov
force-pushed
the
fix-rdar156095800
branch
2 times, most recently
from
85d6fab to
ae4723f
Compare
It seems that the restriction preventing these from working was lifted. The behavioral difference is that in Swift 5 mode, we don't actually open AnyObject like this, so the old operator could not be used with class-bound existentials. I added a trivial test case just to ensure that calls to === type check correctly in both language modes. Fixes rdar://156095800.
slavapestov
force-pushed
the
fix-rdar156095800
branch
from
ae4723f to
b7766b6
Compare
slavapestov
changed the title
Contributor
Author
|
The stdlib was completely wrong in the first version, it's fixed now. |
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two unrelated issues:
As a result, attempting === on two class-bound existentials would just crash.
Fixes rdar://156095800.