Mangling: Make sure we have different names for function overloads with all args in a tuple. #8323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please smoke test and merge |
Contributor
|
This is also SR-1795 and rdar://21655241. |
Contributor
|
Another test case: func foo(_: ()) {}
func foo() {} |
Contributor
|
Another case we currently get wrong is varargs that are not in the last argument position. @jckarter knows the details. |
Contributor
|
That one's SR-1076. :-) |
…th all args in a tuple. For example: public func test(_ a: Int, _ b: Int) public func test(_ t: (Int, Int)) fixes rdar://problem/31211238
eeckstein
force-pushed
the
arg-tuple-mangling
branch
from
72b3072 to
11f66f8
Compare
Contributor
Author
|
@swift-ci Please smoke test and merge |
Contributor
Author
|
@jrose-apple Thanks for the additional test case! |
Contributor
Author
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
public func test(_ a: Int, _ b: Int)
public func test(_ t: (Int, Int))
fixes rdar://problem/31211238