[Strict memory safety] "unsafe" expression never propagates unsafe outward #83109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tward In the effects checker, we were propagating the "has an unsafe use site" outside of an `unsafe` expression. The result of this is that we would not produce a warning for silly expressions like `unsafe unsafe ptr.pointee`, where the first (outer) `unsafe` is unnecessary. Stop propagating that bit so we properly diagnose the spurious "unsafe". Fixes issue swiftlang#82315 / rdar://153672668.
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please smoke test macOS |
xedin
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the effects checker, we were propagating the "has an unsafe use site" outside of an
unsafeexpression. The result of this is that we would not produce a warning for silly expressions likeunsafe unsafe ptr.pointee, where the first (outer)unsafeis unnecessary. Stop propagating that bit so we properly diagnose the spurious "unsafe".Fixes issue #82315 / rdar://153672668.