[IRGen] Don't use mangled names for metadata including Span et al when back-deploying #83012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please smoke test |
slavapestov
approved these changes
Jul 11, 2025
DougGregor
force-pushed
the
no-mangled-name-span-metadata
branch
from
03a299e to
f79b003
Compare
…n back-deploying If back-deploying prior to the introduction of name mangling and runtime support for invertible constraints (~Copyable, ~Escapable), don't use mangled names to access metadata. The code already existed for this, but had a carve-out that still used mangled names for standard library types that have always existed but got generalized to support non-copyable & non-escapable types. Tweak that carve-out to not apply to types like Span that come from a back-deployment library. Fixes crashes when using metadata for Span et al on older platforms. Fixes rdar://155639204.
…uced in Swift 6.2 We can't use mangled named when back-deploying earlier.
DougGregor
force-pushed
the
no-mangled-name-span-metadata
branch
from
f79b003 to
badba55
Compare
Member
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If back-deploying prior to the introduction of name mangling and runtime support for invertible constraints (~Copyable, ~Escapable), don't use mangled names to access metadata. The code already existed for this, but had a carve-out that still used mangled names for standard library types that have always existed but got generalized to support non-copyable & non-escapable types.
Tweak that carve-out to not apply to types like Span that come from a back-deployment library. Fixes crashes when using metadata for Span et al on older platforms.
While I'm here, also fix
nonisolated(nonsending)function types, which have a similar issue because they were introduced in Swift 6.2.Fixes rdar://155639204.