[6.2][Concurrency] Don't downgrade explicit isolation attribute clashes #82998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler shouldn't accept mismatch in explicit isolation attributes because it could lead to incorrect isolation selection. Resolves: rdar://155589753 (cherry picked from commit a9373c0)
Contributor
Author
|
@swift-ci please test |
hborla
approved these changes
Jul 11, 2025
Contributor
Author
|
@swift-ci please test macOS platform |
1 similar comment
Contributor
Author
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
The compiler shouldn't accept mismatch in explicit isolation attributes because it could lead to incorrect isolation selection.
Resolves: rdar://155589753
Main Branch PR: [Concurrency] Don't downgrade explicit isolation attribute clashes #82925
Risk: Low. This was never accepted before and our qualification uncovered no situations were with this change the compiler would produce an erorr.
Reviewed By: @gottesmm
Testing: Updated existing test-cases.
(cherry picked from commit a9373c0)