[6.2] Fix SILCombine of inject_enum_addr when the enum is non-trivial but payload is trivial #82980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… but payload is trivial
Contributor
Author
|
@swift-ci test |
tbkka
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The SILCombine was using the type of inject_enum_data_addr 's operand instead of its result leading to creating of load instruction with invalid qualifier triggering ownership error.
Scope: Optimized swift code with enums
Issue: Fixes #82813
Main PR: #82978
Reviewer: @nate-chandler
Risk: Low
Testing: Swift CI testing