Skip to content

Conversation

@hamishknight
Copy link
Contributor

@hamishknight hamishknight commented Jul 10, 2025

The logic here was unnecessary, the SourceRange gets converted to a CharSourceRange in the function being called, which handles raw identifiers correctly. 6.2-only since this is already fixed on main (adding test case in #82952).


  • Explanation: Fixes raw identifier handling in the semantic tokens request, previously we could report an incorrect range if the identifier contained characters such as spaces.
  • Scope: Affects the semantic tokens request
  • Issue: rdar://152273926
  • Risk: Low, only affects semantic tokens request, and the fix is straightforward
  • Testing: Added tests to test suite
  • Reviewer: Ben Barham

The logic here was unnecessary, the SourceRange gets converted to a
CharSourceRange in the function being called, which handles raw
identifiers correctly. 6.2-only since this is already fixed on main.

rdar://152273926
@hamishknight hamishknight requested a review from bnbarham July 10, 2025 14:30
@hamishknight hamishknight requested a review from a team as a code owner July 10, 2025 14:30
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit cbad87d into swiftlang:release/6.2 Jul 11, 2025
5 checks passed
@hamishknight hamishknight deleted the ident-range-6.2 branch July 11, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants