ClangImporter: permit redundancy in the Generate PCM job #82935
Merged
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-Xcc` flags are internal to the C compiler; we have `-vfsoverlay` now which directly passes the VFS overlay. Because the VFS overlay flags are automatically passed along to the clang scanner, we need to pass along `-vfsoverlay` to the Swift frontend to ensure that any VFS overlays are honoured. Most likely this was a workaround for `-vfsoverlay` not getting propagated originally and when the restriction was lifted the exercised codepath was not heavily tested.
compnerd
requested review from
Xazax-hun,
beccadax,
egorzhdan,
fahadnayyar,
ian-twilightcoder,
j-hui,
susmonteiro and
zoecarver
as code owners
Member
Author
|
@swift-ci please smoke test |
artemcm
approved these changes
Jul 9, 2025
cachemeifyoucan
approved these changes
Jul 10, 2025
Contributor
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
Thanks for fixing. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Xccflags are internal to the C compiler; we have-vfsoverlaynow which directly passes the VFS overlay. Because the VFS overlay flags are automatically passed along to the clang scanner, we need to pass along-vfsoverlayto the Swift frontend to ensure that any VFS overlays are honoured. Most likely this was a workaround for-vfsoverlaynot getting propagated originally and when the restriction was lifted the exercised codepath was not heavily tested.