[6.2] [Runtime] Don't fail conformances when the global actor hook is missing #82816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the concurrency library's "is current global actor" hook is not available, assume that we are already executing on the right global actor. This mimics the behavior of earlier standard libraries when faced with an isolated conformance, as well as dealing with odd configurations where the code might not load the concurrency library yet At the moment, WebAssembly ends up in this configuration because we don't run the initialization for the concurrency library. That makes this also a workaround for issue swiftlang#82682 / rdar://154762027.
Member
Author
|
@swift-ci please test |
ktoso
approved these changes
Jul 7, 2025
Contributor
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
I think this is probably good enough -- runtimes which are actually multithreaded would have the check/hook available AFAIK so this should be ok.
airspeedswift
approved these changes
Jul 7, 2025
DougGregor
deleted the
isolated-conformance-without-concurrency-runtime-6.2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.defaultIsolation(MainActor.self)breaks cross-module protocol conformance when building with--static-swift-stdlib#82682 / rdar://154762027