Skip to content

[6.2] [Completion] Map failable initializer result type into context #82803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

[6.2] [Completion] Map failable initializer result type into context #82803

merged 1 commit into from
Jul 7, 2025

Conversation

@hamishknight
Copy link
Contributor

@hamishknight hamishknight commented Jul 4, 2025 •
edited
Loading

6.2 cherry-pick of #82802

  • Explanation: Fixes a crash that could occur when doing code completion at the top-level or in a return within a failable initializer
  • Scope: Affects code completion
  • Issue: rdar://155038769
  • Risk: Low, only affects completion, and the fix is straightforward
  • Testing: Added tests to test suite
  • Reviewer: Ben Barham

@hamishknight
[Completion] Map failable initializer result type into context
9671ed9 
Make sure we don't pass an interface type to `setTypeContext`.

rdar://155038769
@hamishknight hamishknight requested a review from bnbarham July 4, 2025 13:01
@hamishknight hamishknight requested a review from a team as a code owner July 4, 2025 13:01
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Jul 4, 2025
@hamishknight
Copy link
Contributor Author

hamishknight commented Jul 4, 2025

@swift-ci please test

@hamishknight hamishknight merged commit 35cbdd8 into swiftlang:release/6.2 Jul 7, 2025
5 checks passed
@hamishknight hamishknight deleted the context-fail-6.2 branch July 7, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees

No one assigned

Labels

🍒 release cherry pick Flag: Release branch cherry picks swift 6.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hamishknight @bnbarham