[6.2][cxx-interop] Fix a crash when exposing @objc Swift classes #82760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explanation: There was a null pointer dereference in reverse interop when we wanted to expose an ObjC class written in Swift. There was a crash during generating the scaffolding we do for Clang types. Since the type is written in Swift, no such scaffolding is needed, this patch skips this operation avoiding the null dereference. Scope: Reverse C++ interop when exposing @objc classes written in Swift. Issues: rdar://154252454 Original PRs: swiftlang#82684 Risk: Low, the fix is narrow to the affected scenario. Testing: Added a compiler test. Reviewers: @egorzhdan
Xazax-hun
added
c++ interop
Contributor
Author
|
@swift-ci please test |
egorzhdan
approved these changes
Jul 3, 2025
DougGregor
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: There was a null pointer dereference in reverse interop when we wanted to expose an ObjC class written in Swift. There was a crash during generating the scaffolding we do for Clang types. Since the type is written in Swift, no such scaffolding is needed, this patch skips this operation avoiding the null dereference.
Scope: Reverse C++ interop when exposing @objc classes written in Swift.
Issues: rdar://154252454
Original PRs: #82684
Risk: Low, the fix is narrow to the affected scenario. Testing: Added a compiler test.
Reviewers: @egorzhdan