[AST] Use ErrorType for invalid value generic parameter #82721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
AnthonyLatsis,
bnbarham,
hborla,
rintaro,
slavapestov and
xedin
as code owners
If we fail to resolve the value type for a value generic parameter, previously we would have returned a null Type, causing crashes downstream. Instead, return an ErrorType, leaving a null Type for cases where the generic parameter isn't a value generic at all. rdar://154856417
Make sure we have a value type for a value generic parameter.
Contributor
Author
|
@swift-ci please test |
xedin
approved these changes
Jul 2, 2025
AnthonyLatsis
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we fail to resolve the value type for a value generic parameter, previously we would have returned a null Type, causing crashes downstream. Instead, return an ErrorType, leaving a null Type for cases where the generic parameter isn't a value generic at all.
rdar://154856417