[Concurency] Allow declarations with @isolated(any) parameters be m…
#82689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
|
@xedin this needs SILGen and potentially a runtime test. |
Contributor
Author
|
Sure, I can add them! |
Contributor
Author
|
@gottesmm I don't think this is any different from any other situation we have though because |
Contributor
Author
|
Do you want to make sure that we are passing the isolation down to that function correctly when it's called? |
…arked as `@concurrent`/`nonisolated(nonsending)` It's shouldn't be possible to use these attributes directly on the function type that is `@isolated(any)` as per SE-0461 proposal but it shouldn't preclude declarations that have parameters with `@isolated(any)` from using them. Resolves: rdar://154754939
Contributor
Author
|
@swift-ci please test |
gottesmm
approved these changes
Jul 1, 2025
Contributor
Author
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…arked as
@concurrent/nonisolated(nonsending)It's shouldn't be possible to use these attributes directly on the function type that is
@isolated(any)as per SE-0461 proposal but it shouldn't preclude declarations that have parameters with@isolated(any)from using them.Resolves: rdar://154754939