🍒[cxx-interop] Do not crash for void begin()
#82688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing C++ methods, Swift always assumes that methods named `begin()` and `end()` are unsafe, since these methods commonly return iterator types that are inherently unsafe in Swift. Some additional logic in Sema tries to diagnose usages of `.begin()` and `.end()` from Swift and suggest safe alternatives. That logic had a null pointer dereference bug. rdar://153814676 / resolves #82361 (cherry picked from commit 883ff18)
Contributor
Author
|
@swift-ci please test |
DougGregor
approved these changes
Jul 1, 2025
Xazax-hun
approved these changes
Jul 1, 2025
Contributor
Author
|
@swift-ci please test macOS |
2 similar comments
Contributor
Author
|
@swift-ci please test macOS |
Contributor
Author
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
begin()andend()are unsafe, since these methods commonly return iterator types that are inherently unsafe in Swift. Some additional logic in Sema tries to diagnose usages of.begin()and.end()from Swift and suggest safe alternatives. That logic had a null pointer dereference bug.void begin()#82627