-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[userdocs] Automatically generate doc indices #82663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So I promised I would add verification for this, but after doing that I realized it was only a few lines off of just generating the files instead and thus... here we are 😅 Interested in opinions here as to if:
|
DougGregor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice, thank you!
|
My thoughts on your questions.
|
artemcm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
|
I don't consider the implementation of (1) to be blocking committing this. It's a great step forward, thank you! |
cachemeifyoucan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I don't know how the swift doc webpage is generated. The alternative to add a test is to make the index generation part of the build steps for the docs.swift.org, but I agree this is not a blocking change.
1815bb0 to
6a9bc52
Compare
|
@swift-ci please test |
|
Thanks for the input everyone!
Easy to add, done.
Sounds fair to me, thanks 🙇♂️
I did consider that, but it's nice to be able to generate the docs locally when writing them. We could have a docs preview script that generates + starts the docc server though 🤔. For now I've just added the validation in. If it gets too annoying, happy to change. |
|
@swift-ci please test macOS platform |
6a9bc52 to
59094e9
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
59094e9 to
e70c8d3
Compare
Add a tool for automatically generating the doc indices for notes, groups, and features.
e70c8d3 to
5ee9133
Compare
|
@swift-ci please test |
Add a tool for automatically generating the doc indices for notes,
groups, and features.