[6.2] [SE-0371] Back-deploy support for main-actor-isolated deinit #82662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DougGregor
commented
Jul 1, 2025
DougGregor
commented
- Explanation: When targeting a platform that predates the introduction of isolated deinit (SE-0371), make a narrow exception that allows main-actor-isolated deinit to work through a special, inlineable entrypoint that is back-deployed.
- Scope: Narrow. Only active when using a new feature (isolated deinit) and deploying prior to its introduction (Spring 2025).
- Issues: rdar://151029118
- Original PRs: [SE-0371] Back-deploy support for main-actor-isolated deinit #82661
- Risk: Low. Changes are limited to code paths for the new feature. code paths.
- Testing: CI
- Reviewers:
When targeting a platform that predates the introduction of isolated deinit, make a narrow exception that allows main-actor-isolated deinit to work through a special, inlineable entrypoint that is back-deployed. This implementation 1. Calls into the real implementation when available, otherwise 2. Checks if we're on the main thread, destroying immediately when we are, otherwise 3. Creates a new task on the main actor to handle destruction. This implementation is less efficient than the implementation in the runtime, but allows us to back-deploy this functionality as far back as concurrency goes. Fixes rdar://151029118.
Member
Author
|
@swift-ci please test |
ktoso
approved these changes
Jul 1, 2025
Member
Author
|
@swift-ci please test |
nkcsgexi
approved these changes
Jul 1, 2025
Member
Author
|
@swift-ci please test |
DougGregor
changed the title
… task-to-thread model
Member
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.